Skip to content

chore: replace <ChooseOne> with alternatives when appropriate #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 2, 2023
Merged

chore: replace <ChooseOne> with alternatives when appropriate #9907

merged 3 commits into from
Oct 2, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 28, 2023 •
edited
Loading

Since we discussed preferring options like returning early and using ternary expressions, I did a couple of relevant refactors

@aslilac aslilac marked this pull request as ready for review September 29, 2023 23:46
Kira-Pilot
Kira-Pilot approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

@aslilac aslilac merged commit 885b250 into main Oct 2, 2023
@aslilac aslilac deleted the less-choose-one branch October 2, 2023 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aslilac @BrunoQuaresma @Kira-Pilot