Skip to content

fix: spurious deprecation warnings in SCSS code #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025

Conversation

arikorn
Copy link
Contributor

@arikorn arikorn commented Jun 30, 2025

move the deprecation @includes inside the css rule

completes issue #979

move the deprecation `@includes` inside the css rule

completes issue coreui#979
@mrholek
Copy link
Member

mrholek commented Jun 30, 2025

@arikorn, thank you for your PR. There is a simpler way to do this. Since we don't use those mixins in our codebase, we can remove them from this file scss/_mixins.scss. Can you update your PR?

@arikorn
Copy link
Contributor Author

arikorn commented Jun 30, 2025

Thanks @mrholek. Pushed the change. I left the other files in this PR alone since I'm assuming you'll remove them anyway if you want. (Or if you do keep those files, it's still better to have the @include inside the css rule...)

@mrholek mrholek changed the title Fix: spurious deprecation warnings in scss code fix: spurious deprecation warnings in SCSS code Jun 30, 2025
@mrholek mrholek merged commit 2892ee5 into coreui:main Jun 30, 2025
@arikorn
Copy link
Contributor Author

arikorn commented Jun 30, 2025

Thank you @mrholek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants