Skip to content

relocated lis to dp section/add redirect + add relevant links to intro-to_dp #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

mhayter
Copy link
Contributor

@mhayter mhayter commented Apr 24, 2025

Did I do this right?

@mhayter mhayter changed the title relocated lis to dp section/add redirect relocated lis to dp section/add redirect + add relevant links to intro-to_dp Apr 24, 2025
@mhayter
Copy link
Contributor Author

mhayter commented Apr 24, 2025

This technically works but probably the links should be edited to be relative as it won't work exactly correctly with absolute links, but I'm dumb and can't figure it out.

Copy link
Member

@adamant-pwn adamant-pwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's cleanup the links a bit.

@@ -63,6 +63,7 @@ search:
- Dynamic Programming
- [Introduction to Dynamic Programming](dynamic_programming/intro-to-dp.md)
- [Knapsack Problem](dynamic_programming/knapsack.md)
- [Longest increasing subsequence](dynamic_programming/longest_increasing_subsequence.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we very deliberately want it to occur in two sections, we should also remove it from Miscellaneous/Sequences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused on what you mean. Don't we need the redirects?

e_maxx_link: longest_increasing_subseq_log
---

<meta http-equiv="refresh" content="0; url=/dynamic_programming/longest_increasing_subsequence.html">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<meta http-equiv="refresh" content="0; url=/dynamic_programming/longest_increasing_subsequence.html">
<meta http-equiv="refresh" content="0; url=../dynamic_programming/longest_increasing_subsequence.html">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? I'd tested my commit and it did work. It seems like it wouldn't now. Is there any easy way to test on the phone lol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ps I'm a little confused on when we should be directing to .md vs html.

mhayter and others added 3 commits June 28, 2025 14:51
Ty

Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Ty

Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants