-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
relocated lis to dp section/add redirect + add relevant links to intro-to_dp #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
forgot to save lol
should this link be relative or absolute?
don't know how markdown works
I don't get markdown links...
This technically works but probably the links should be edited to be relative as it won't work exactly correctly with absolute links, but I'm dumb and can't figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's cleanup the links a bit.
@@ -63,6 +63,7 @@ search: | |||
- Dynamic Programming | |||
- [Introduction to Dynamic Programming](dynamic_programming/intro-to-dp.md) | |||
- [Knapsack Problem](dynamic_programming/knapsack.md) | |||
- [Longest increasing subsequence](dynamic_programming/longest_increasing_subsequence.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we very deliberately want it to occur in two sections, we should also remove it from Miscellaneous/Sequences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused on what you mean. Don't we need the redirects?
e_maxx_link: longest_increasing_subseq_log | ||
--- | ||
|
||
<meta http-equiv="refresh" content="0; url=/dynamic_programming/longest_increasing_subsequence.html"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<meta http-equiv="refresh" content="0; url=/dynamic_programming/longest_increasing_subsequence.html"> | |
<meta http-equiv="refresh" content="0; url=../dynamic_programming/longest_increasing_subsequence.html"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? I'd tested my commit and it did work. It seems like it wouldn't now. Is there any easy way to test on the phone lol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ps I'm a little confused on when we should be directing to .md vs html.
Ty Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Ty Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Co-authored-by: Oleksandr Kulkov <adamant.pwn@gmail.com>
Did I do this right?