Fixed #36482 -- Rendered PK with value_to_string() in admin. #19600
+28
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
commented
Jun 28, 2025
Comment on lines
+687
to
+689
| @property | ||
| def pk_str(self): | ||
| return self._meta.pk.value_to_string(self) |
There was a problem hiding this comment.
I know adding this may be contentious but we could use it everywhere else value_to_string() is used - in serialisation & sessions.
shangxiao
commented
Jun 28, 2025
django/db/models/fields/json.py
Outdated
Comment on lines
137
to
144
| def to_python(self, value): | ||
| return json.loads(value) | ||
|
|
||
| def value_to_string(self, obj): | ||
| return self.value_from_object(obj) | ||
| return json.dumps(self.value_from_object(obj)) |
There was a problem hiding this comment.
This is a separate issue(?) that I noticed while trying to find a suitable way to setup a unit test: JSONField wasn't doing any proper json conversion to/from string values. Perhaps nobody cares 🤷♂️
…e_to_string()... - JSONField had no to_python() so the base implementation was used. - value_to_string() was simply deferring to value_from_object() without json processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36482
Branch description
This PR demonstrates how to render a PK "correctly", using
field.value_to_string(obj), so thatget_object()will correctly retrieve value when it usesto_python()to deserialise the PK back to a Python type.You can test this with the following example:
Note that there are places that still need updating, like here where the pk is
rendered as a string directlypassed toquote()inside the template where we cannot usefield.value_to_string(obj):django/django/contrib/admin/templates/admin/change_form_object_tools.html
Line 4 in a388287
Checklist
mainbranch.