Skip to content

Removed verbose "which" from migrations topic #19607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmoppel
Copy link

@jmoppel jmoppel commented Jun 29, 2025

Branch description

Trivial changes to migrations topic in docs. Removed "which" and "which is" phrases, where they are overly verbose. This change is intended to make the migrations topic a bit more concise and easier to read.

Also fixes a very minor (preexisting) spelling error.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Jun 29, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@jmoppel jmoppel force-pushed the docs_reduce_verbosity_of_migration_command_desc branch 2 times, most recently from cb249ba to 86488dc Compare June 29, 2025 21:26
@shangxiao
Copy link
Contributor

Anything to make the docs more concise gets a 👍 from me but you'll need to replace the commas with colon ":" on those dot points

ie:

  • makemigrations: generates migrations etc etc

* Removed the words "which" and "which is" from the migrations topic,
where it is overly verbose. This makes the migrations topic a bit
more concise and easier to read.

* Fixed a small pre-existing spelling error ("unapplies").

* Replaced commas with colons after the defined term in bulleted list.
@jmoppel jmoppel force-pushed the docs_reduce_verbosity_of_migration_command_desc branch from 86488dc to 3ed6c46 Compare June 30, 2025 21:27
@jmoppel
Copy link
Author

jmoppel commented Jun 30, 2025

I've replaced the commas with colons, as you suggested. I didn't care for the commas either when I first saw them, but didn't want to change too much in my first commit (considering there isn't a Trac Ticket). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no ticket Based on PR title, no linked Trac ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants