Add support for custom field types w/ Solr backend #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdha
reviewed
Oct 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 33.62% 33.62%
=======================================
Files 34 34
Lines 1972 1972
=======================================
Hits 663 663
Misses 1309 1309Continue to review full report at Codecov.
|
acdha
reviewed
Feb 26, 2020
acdha
previously approved these changes
Mar 5, 2020
acdha
reviewed
Mar 5, 2020
acdha
reviewed
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Solr backend supported only
text_enforCharFieldwhich is not appropriate for some use-cases. You can now derive a custom Field with a get_field_type method which delivers the required field-type.