Good catch, @DhavalGojiya

Is there any way to create a test that fails on the current code and proves that this change fixes that failure?

Is there any way to create a test that fails on the current code and proves that this change fixes that failure?

To reproduce the issue, update settings.py in your Django project with the following configuration:

HAYSTACK_CONNECTIONS = {
    'default': {
        'ENGINE': 'haystack.backends.solr_backend.SolrEngine',
        'URL': 'http://localhost:9001/solr/my_core/',
        'TIMEOUT': 60 * 5,
        'INCLUDE_SPELLING': True,
        'BATCH_SIZE': 100,
        'EXCLUDED_INDEXES': ['thirdpartyapp.search_indexes.BarIndex']
    }
}

Running the reload-core management command will fail because it cannot parse "my_core" from the URL due to the trailing slash.
Note: Slash at the end or not doesn't affect any Solr API, but Django haystack Python code depends on it and it's very common for developers to add the slash at the end of the url.

To fix this, remove the trailing slash from the URL:

'URL': 'http://localhost:9001/solr/my_core'

My PR corrects this issue by handling URLs with or without a trailing slash.

Attach: Image attached for the failure of this management command when there is slash at the end in URL
CC : @yatishTrootech | @cclauss | @acdha

Is there any way to create a test that fails on the current code and proves that this change fixes that failure?

To reproduce the issue, update settings.py in your Django project with the following configuration:

HAYSTACK_CONNECTIONS = {
    'default': {
        'ENGINE': 'haystack.backends.solr_backend.SolrEngine',
        'URL': 'http://localhost:9001/solr/my_core/',
        'TIMEOUT': 60 * 5,
        'INCLUDE_SPELLING': True,
        'BATCH_SIZE': 100,
        'EXCLUDED_INDEXES': ['thirdpartyapp.search_indexes.BarIndex']
    }
}

Running the reload-core management command will fail because it cannot parse "my_core" from the URL due to the trailing slash. Note: Slash at the end or not doesn't affect any Solr API, but Django haystack Python code depends on it and it's very common for developers to add the slash at the end of the url.

To fix this, remove the trailing slash from the URL:

'URL': 'http://localhost:9001/solr/my_core'

My PR corrects this issue by handling URLs with or without a trailing slash.

Attach: Image attached for the failure of this management command when there is slash at the end in URL CC : @yatishTrootech | @cclauss

PS: I will try to develop the test case for what you are talking about very soon.

Or it will be better if you record a video of test case and upload it here

Thanks! However test_haystack/solr_tests/test_solr_management_commands.py should be completed with a regression test for this fix.

Thank you for your response. I have rebased from the master branch and pushed again, so my previous commit is no longer present. I will try to add regression test case for this very soon.

@cclauss | @claudep
The requested test cases have been added to test_haystack/solr_tests/test_solr_management_commands.py.

Added test cases:

• test_build_solr_schema_reload_core_with_trailing_slash
• test_build_solr_schema_reload_core_without_trailing_slash

Test Results:

@cclauss | @claudep The requested test cases have been added to test_haystack/solr_tests/test_solr_management_commands.py.

Added test cases:

• test_build_solr_schema_reload_core_with_trailing_slash
• test_build_solr_schema_reload_core_without_trailing_slash

Test Results:

Seems good to me @DhavalGojiya