Skip to content

GitHub Actions: test in Solr 8 #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

GitHub Actions: test in Solr 8 #1976

wants to merge 6 commits into from

Conversation

nikolas
Copy link

@nikolas nikolas commented Jun 28, 2024 •
edited by cclauss
Loading

I am currently using django-haystack with Solr 8 and it seems to be working well. I think we can move the docs and testing to at least be current with this Solr version. The current stable Solr release series is 9.x.

@claudep
Copy link
Contributor

claudep commented Jun 29, 2024

Thanks! You should rebase your PR once #1977 is merged.

cclauss
cclauss previously approved these changes Jun 29, 2024
View reviewed changes
@cclauss cclauss requested a review from claudep June 29, 2024 20:25
claudep
claudep requested changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like wait-for-solr strikes again 😭

@cclauss
Copy link
Contributor

cclauss commented Jun 30, 2024

Solr Tests
6 Pass
7 Fail
8 Fail
9 Fail

@claudep
Copy link
Contributor

claudep commented Jun 30, 2024

I'm afraid it's not that simple to test against new versions of solr. Files in test_haystack/solr_tests/server/* need updating too, by someone with sufficient solr knowledge (aka not me!).

@cclauss cclauss mentioned this pull request Jul 8, 2024
Open
@cclauss
Copy link
Contributor

cclauss commented Jul 9, 2024

@black3r Do you have any hints for us on how to get the tests to pass on modern versions of Solr?

nikolas and others added 3 commits July 9, 2024 11:35
@nikolas
GitHub Actions: test in Solr 8
62a6bec 
I am currently using django-haystack with Solr 8 and it seems to be working well. I think we can move the docs and testing to at least be current with this Solr version. The current stable Solr release series is 9.x.
@cclauss @nikolas
matrix: solr-version: [6, 7, 8, 9]
abbe8be
@nikolas
Update test solr docker to 8.11.3
a1210bd
@nikolas
Copy link
Author

nikolas commented Jul 9, 2024

I've made some updates to the test solr docker config - tests are now failing at this step which doesn't seem related:

prettier.................................................................Failed
- hook id: prettier
- files were modified by this hook

?25h.github/workflows/test.yml

I don't see any mention of prettier in the source repo - what is this referring to?

@cclauss
Copy link
Contributor

cclauss commented Jul 9, 2024 •
edited
Loading

We can ignore the pre-commit vs. prettier thing... I will fix that in #1982.

@cclauss cclauss mentioned this pull request Jul 10, 2024
Open
@cclauss cclauss mentioned this pull request Jul 10, 2024
Draft
@cclauss cclauss mentioned this pull request Nov 1, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep requested changes

@cclauss cclauss cclauss left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@claudep claudep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolas @claudep @cclauss