Issue #1992: Implemented handling for track_total_hits in the Elasticsearch search backend.
#1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HAYSTACK_TRACK_TOTAL_HITS Setting to Constants - Added `HAYSTACK_TRACK_TOTAL_HITS` to `haystack/constants.py`. - This setting allows configuration of the `track_total_hits` parameter in Elasticsearch queries. - Valid options are of type `bool` or `int`. - Default value is `False`, meaning the `track_total_hits` parameter will be omitted by default.
Support track_total_hits Handling in ElasticsearchSearchBackend - Implemented handling for `track_total_hits` in the Elasticsearch search backend. - Supports `bool` values (True/False) and `int` values. - Added a warning for invalid `track_total_hits` values. - Ensured the parameter is only added to search kwargs when valid.
…Setting - Documented the `HAYSTACK_TRACK_TOTAL_HITS` setting in the search backend configuration. - Explained the impact of setting values: `True`, `int`, and `False`. - Included examples for configuring `HAYSTACK_TRACK_TOTAL_HITS`. - Default behavior is noted as `False`, meaning the `track_total_hits` parameter is omitted by default.
Removed unnecessary blank line and replaced search_kwargs with kwargs, to resolve automated test errors
…ndTrackTotalHitsTestCase Implemented to verify the correct handling of in Elasticsearch 7.
Relocated the logic from to as this feature is only supported in Elasticsearch 7 and higher.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1992 (comment)
track_total_hitsin the Elasticsearch search backend.boolvalues (True/False) andintvalues.track_total_hitsvalues.HAYSTACK_TRACK_TOTAL_HITSsetting in the search backend configuration.track_total_hitsin Elasticsearch 7.