[EIS] Rename the elser 2 default model and the default inference endpoint #130336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @timgrein, I've created a changelog YAML for you. |
…ence-endpoint' into rename-eis-elser-model-and-inference-endpoint
| @@ -41,7 +41,7 @@ public void testGetDefaultEndpoints() throws IOException { | |||
| } | |||
|
|
|||
| assertInferenceIdTaskType(allModels, ".rainbow-sprinkles-elastic", TaskType.CHAT_COMPLETION); | |||
| assertInferenceIdTaskType(allModels, ".elser-v2-elastic", TaskType.SPARSE_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".elser-2-elastic", TaskType.SPARSE_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".multilingual-embed-v1-elastic", TaskType.TEXT_EMBEDDING); | |||
| assertInferenceIdTaskType(allModels, ".rerank-v1-elastic", TaskType.RERANK); | |||
There was a problem hiding this comment.
Do we need to remove v from the text embedding and rerank default endpoint names too?
There was a problem hiding this comment.
Nope, we'll only do the adjustment for ELSER to be en par with the ML node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided to rename the default model and default inference endpoint for elser running EIS. This needs to be backported to
9.1and8.19and we consider it as a bug as multiple other places (will) depend on these new names