Add XmlProcessor initial implementation #130337
Open
+1,352
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
elasticsearchmachine
added
v9.2.0
external-contributor
marc-gr
force-pushed
the
feat/xml-processor
branch
from
5bd50d5 to
95df637
Compare
marc-gr
force-pushed
the
feat/xml-processor
branch
from
95df637 to
67dd264
Compare
elasticsearchmachine
added
the
needs:triage
There was a problem hiding this comment.
Pull Request Overview
Adds a new XML pipeline processor that parses XML into JSON-like maps using a streaming parser, with options for error handling, case conversion, and empty-value filtering.
- Introduces
XmlProcessorwith configurable parsing options - Provides factory integration, plugin registration, and comprehensive unit tests
- Updates module dependencies and documentation for the XML processor
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/XmlProcessor.java | New processor implementation with streaming XML parsing |
| modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/XmlProcessorTests.java | Unit tests covering parsing scenarios and options |
| modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/XmlProcessorFactoryTests.java | Tests for factory config and defaults |
| modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/IngestCommonPlugin.java | Registered XML processor in plugin |
| modules/ingest-common/src/main/java/module-info.java | Added java.xml module requirement |
| docs/reference/enrich-processor/xml-processor.md | Documentation for the XML processor |
| docs/reference/enrich-processor/toc.yml | Added processor to TOC |
| docs/reference/enrich-processor/index.md | Linked XML processor in index |
Comments suppressed due to low confidence (2)
docs/reference/enrich-processor/xml-processor.md:12
- [nitpick] Verify that the
$$$xml-options$$$macro is correct and renders all available XML processor options in the docs.
$$$xml-options$$$
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/XmlProcessor.java:185
- [nitpick] There are no tests for XML namespace handling. Consider adding a unit test with namespace-qualified elements to validate namespace awareness settings.
factory.setProperty(XMLInputFactory.IS_NAMESPACE_AWARE, false);
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/XmlProcessor.java
Outdated
Show resolved
Hide resolved
modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/XmlProcessor.java
Show resolved
Hide resolved
marc-gr
added
the
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
removed
the
needs:triage
|
Hi @marc-gr, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new Xml pipeline processor
Closes #97364