Skip to content

Update eslint, introduce prettier & run lint:fix #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alubbe
Copy link
Member

@alubbe alubbe commented Jan 17, 2019

As discussed in #722, this PR applies automated code transformations (and some manual replacements of var inside switch statements and double assignments) to drag the code base into the new world :)

@alubbe
Copy link
Member Author

alubbe commented Jan 17, 2019

I can't even assign reviewers - what access rights do I have?

@papandreou
Copy link
Contributor

I love prettier, but with 15 other PRs open, this doesn't seem like the right time to introduce it.

In my experience it will cause most of them to end up in a conflicted state, which is not what this project needs right now.

@alubbe
Copy link
Member Author

alubbe commented Jan 17, 2019

I agree - let's delay it. happy to update this PR when the others are merged. I just want to make sure we don't include these refactorings in the other PRs.

@alubbe alubbe force-pushed the prettier-refactoring branch from 9f9f239 to 8d5f099 Compare January 18, 2019 09:54
@alubbe alubbe force-pushed the prettier-refactoring branch from 8d5f099 to 258743f Compare January 18, 2019 10:47
@alubbe alubbe force-pushed the prettier-refactoring branch from 258743f to cee23d4 Compare January 18, 2019 11:03
@Siemienik
Copy link
Member

@alubbe I really dislike do changes in all files in one time, it will make a lot of conflicts
I recommend do it step by step with other changes. it's much more soft solution

@guyonroche
Copy link
Collaborator

@alubbe I've downloaded this branch and fixed the collisions. I've pushed into a new local branch here: prettier-refactoring
Not sure yet when is the best time to merge it in - there are still a bunch of PRs to wade through

@alubbe
Copy link
Member Author

alubbe commented Apr 9, 2019

I'm happy to fix those by hand - it's as simple as accepting the changes and re-running the linter

@alubbe alubbe closed this Apr 17, 2019
@alubbe alubbe deleted the prettier-refactoring branch April 17, 2019 12:58
@alubbe
Copy link
Member Author

alubbe commented Apr 17, 2019

@guyonroche I've merged #774 in favour of this PR. If you like, just run the linter on the entire repo and commit it - or we wait PR by PR to apply it file by file; just let us know which you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants