-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update eslint, introduce prettier & run lint:fix #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can't even assign reviewers - what access rights do I have? |
I love prettier, but with 15 other PRs open, this doesn't seem like the right time to introduce it. In my experience it will cause most of them to end up in a conflicted state, which is not what this project needs right now. |
I agree - let's delay it. happy to update this PR when the others are merged. I just want to make sure we don't include these refactorings in the other PRs. |
9f9f239
to
8d5f099
Compare
8d5f099
to
258743f
Compare
258743f
to
cee23d4
Compare
@alubbe I really dislike do changes in all files in one time, it will make a lot of conflicts |
@alubbe I've downloaded this branch and fixed the collisions. I've pushed into a new local branch here: prettier-refactoring |
I'm happy to fix those by hand - it's as simple as accepting the changes and re-running the linter |
@guyonroche I've merged #774 in favour of this PR. If you like, just run the linter on the entire repo and commit it - or we wait PR by PR to apply it file by file; just let us know which you prefer |
As discussed in #722, this PR applies automated code transformations (and some manual replacements of
var
insideswitch
statements and double assignments) to drag the code base into the new world :)