1.0: in_http: Add Authorization auth mechanism document #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
kenhys
reviewed
Dec 14, 2021
|
Hmm, using GitHub suggestion commit breaks DCO. I'll fix it later. |
Co-authored-by: Kentaro Hayashi <kenhys@gmail.com> Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
cosmo0920
force-pushed
the
1.0-in_http-authorization
branch
from
7d5da49 to
6317fa8
Compare
ashie
reviewed
Dec 15, 2021
|
|
||
| If you set `Basic <<Base64 encoded string>>` to `authorization_token`, `in_http` verifies `Authorization` HTTP header as token for authentication. | ||
| This `authorization_token` can handle not only Basic authentication but also other types of authentications. | ||
| `authentication_token` will be interpreted as `<type>` and `<credentials>`: |
There was a problem hiding this comment.
- authentication_token
+ authorization_token
ashie
requested changes
Dec 15, 2021
| ``` | ||
| Authorization: <type> <credentials> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Could you describe an example value like this?: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Authorization#basic_authentication
|
The patch is rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hiroshi Hatake hatake@calyptia.com