Skip to content

system-config: some options should not be under <log> section #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

system-config: some options should not be under <log> section #588

merged 1 commit into from
Jun 25, 2025

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jun 24, 2025

@daipom
system-config: some options should not be under <log> section
49a4352 
Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom requested review from Watson1978 and kenhys June 24, 2025 07:42
@kenhys
Copy link
Contributor

kenhys commented Jun 25, 2025

Thanks!

Oh...
It was introduced by #358

kenhys
kenhys approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 188e817 into fluent:1.0 Jun 25, 2025
2 checks passed
@daipom daipom deleted the systemconfig-some-options-should-not-be-under-log branch June 25, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenhys kenhys kenhys approved these changes

@Watson1978 Watson1978 Awaiting requested review from Watson1978

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daipom @kenhys