Skip to content

buffer-section: fix inaccurate description about compress option #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Jun 27, 2025

https://docs.fluentd.org/configuration/buffer-section#buffering-parameters

It is Chunk#write_to to decompress the chunk automatically.

The current description sounds like it has already been decompressed before Output#write.

Signed-off-by: Daijiro Fukuda <fukuda@clear-code.com>
@daipom daipom requested review from Watson1978 and kenhys June 27, 2025 04:52
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 62c95c3 into fluent:1.0 Jun 27, 2025
2 checks passed
@daipom daipom deleted the buffer-section-fix-inaccurate-description-about-compress-option branch June 27, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants