Skip to content

C++: fix (no string representation) for ConstructorInit #19907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025

Conversation

IdrissRio
Copy link
Contributor

@IdrissRio IdrissRio commented Jun 27, 2025

This PR overrides toString for ConstructorInit, which previously had no string representation. It also overrides toString for ConstructorBaseInit while preserving the existing behavior.

Coding Standards PR: github/codeql-coding-standards#916

@github-actions github-actions bot added the C++ label Jun 27, 2025
@IdrissRio IdrissRio changed the title C++: fix \(no string representation)\ for \ConstructorInit\ C++: fix (no string representation) for ConstructorInit Jun 27, 2025
@IdrissRio IdrissRio added the no-change-note-required This PR does not need a change note label Jun 27, 2025
@IdrissRio IdrissRio force-pushed the idrissrio/no-string-representation branch from 373b05e to a2be995 Compare June 30, 2025 07:13
@IdrissRio IdrissRio marked this pull request as ready for review June 30, 2025 10:32
@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 10:32
@IdrissRio IdrissRio requested a review from a team as a code owner June 30, 2025 10:32
@jketema
Copy link
Contributor

jketema commented Jun 30, 2025

Could you run some DCA, just to be sure?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@IdrissRio IdrissRio force-pushed the idrissrio/no-string-representation branch from a2be995 to 62e55ed Compare June 30, 2025 15:12
@jketema jketema merged commit d5c7905 into main Jul 1, 2025
14 of 15 checks passed
@jketema jketema deleted the idrissrio/no-string-representation branch July 1, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants