Skip to content

Rust: Fix variable capture inconsistencies #19916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

Rust: Fix variable capture inconsistencies #19916

merged 1 commit into from
Jun 30, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 30, 2025 •
edited
Loading

#19702 follow-up.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jun 30, 2025
@hvitved hvitved force-pushed the rust/fix-capture-inconsistencies branch from 0c12c4b to 57661df Compare June 30, 2025 08:19
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jun 30, 2025
@hvitved hvitved marked this pull request as ready for review June 30, 2025 11:22
@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 11:22
@hvitved hvitved requested a review from a team as a code owner June 30, 2025 11:22
@hvitved hvitved requested a review from geoffw0 June 30, 2025 11:22
Copilot
Copilot AI reviewed Jun 30, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

geoffw0
geoffw0 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. DCA indicates a > 90% reduction in SSA inconsistencies! 🎉

@hvitved hvitved merged commit 97412f4 into github:main Jun 30, 2025
22 checks passed
@hvitved hvitved deleted the rust/fix-capture-inconsistencies branch June 30, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 geoffw0 approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @geoffw0