Skip to content

Rust: Disambiguate more method calls based on argument types #19927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rust: Disambiguate more method calls based on argument types #19927

wants to merge 2 commits into from
+2,121 −2,009

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jun 30, 2025 •
edited
Loading

#19749 follow-up.

Identifies more overlapping trait implementations, which can lead to an explosion in inferred types (as demonstrated by the added tests).

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Jun 30, 2025
@hvitved hvitved force-pushed the rust/type-inference-overlap3 branch 4 times, most recently from 457aeee to ee774f5 Compare July 1, 2025 08:35
@hvitved hvitved force-pushed the rust/type-inference-overlap3 branch from ee774f5 to add2e0f Compare July 1, 2025 12:22
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jul 1, 2025
@hvitved hvitved marked this pull request as ready for review July 1, 2025 13:35
@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 13:35
@hvitved hvitved requested a review from a team as a code owner July 1, 2025 13:35
@hvitved hvitved requested a review from geoffw0 July 1, 2025 13:45
Copilot
Copilot AI reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@geoffw0 geoffw0 Awaiting requested review from geoffw0

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hvitved