Skip to content

C++: synchronize dbscheme #19935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

C++: synchronize dbscheme #19935

merged 3 commits into from
Jul 1, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jun 30, 2025 •
edited
Loading

Based on #13302

This PR synchronizes the common dbscheme fragments used by C++ with other languages and adds C++ to the CI check that validates that all common fragments are identical across languages.

The most important changes to the dbscheme are:

  • svn-related tables have been dropped; these are unused by any of our QL libraries and the svn extractor no longer exists.
  • The type of the "file" column of the locations_default table is narrowed from @container to @file. The extractor never produces location information for "folders", so switching to @file and matching the dbscheme of all other languages is the right way to go.
  • Drops @location everywhere in favor of @location_default

@github-actions github-actions bot added the C++ label Jun 30, 2025
@jketema jketema added depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note labels Jun 30, 2025
@jketema jketema marked this pull request as ready for review July 1, 2025 05:32
@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 05:32
@jketema jketema requested a review from a team as a code owner July 1, 2025 05:32
Copilot
Copilot AI reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

IdrissRio
IdrissRio approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jketema jketema merged commit a791640 into github:main Jul 1, 2025
22 of 23 checks passed
@jketema jketema deleted the sync-dbscheme-cpp branch July 1, 2025 07:51
@jketema jketema mentioned this pull request Jul 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@IdrissRio IdrissRio IdrissRio approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @IdrissRio