This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Prefer implicit getters on computed properties #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed by @robrix in ReactiveCocoa/ReactiveCocoa#1382 (comment). /cc @github/mac
jspahrsummers
added a commit
to ReactiveCocoa/ReactiveCocoa
that referenced
this pull request
Jul 13, 2014
|
|
||
| Style guide & coding conventions for Swift projects | ||
| When possible, omit the `get` keyword on computed properties that cannot be written to. |
There was a problem hiding this comment.
I don't think that's strictly accurate, because a read-only property might not be idempotent. Unless you intended that anything following this style should be?
There was a problem hiding this comment.
Good point. read-only properties then.
|
Suggest calling out |
|
@robrix Can you demonstrate what you mean? |
|
For read-only subscripts, do: subscript (index: Int) -> T {
…
}not: subscript (index: Int) -> T {
get {
…
}
} |
|
👍 |
|
👍👍 |
|
💳 |
|
|
robrix
added a commit
that referenced
this pull request
Jul 22, 2014
Prefer implicit getters on computed properties
robrix
pushed a commit
that referenced
this pull request
Mar 23, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed by @robrix in ReactiveCocoa/ReactiveCocoa#1382 (comment).
/cc @github/mac