-
Notifications
You must be signed in to change notification settings - Fork 664
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: github-aws-runners/terraform-aws-github-runner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.5.9
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: github-aws-runners/terraform-aws-github-runner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.5.10
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 9 files changed
- 6 contributors
Commits on Jun 19, 2025
-
fix(docs): github artifact attestation command in release notes (#4624)
Looks like the subcommand has changed to `attestation`: https://cli.github.com/manual/gh_attestation
Configuration menu - View commit details
-
Copy full SHA for ff39d4f - Browse repository at this point
Copy the full SHA ff39d4fView commit details
Commits on Jun 23, 2025
-
chore(ci): Add sigstore bundle to release (#4627)
Adding sigstore bundle to release, see https://github.com/ossf/scorecard/blob/main/docs/checks.md#signed-releases
Configuration menu - View commit details
-
Copy full SHA for d3b5e27 - Browse repository at this point
Copy the full SHA d3b5e27View commit details -
fix(ami-housekeeper): don't delete referenced AMIs in default config (#…
…4623) In 472cc5f the default config was migrated to use SSM for AMI lookup. A parameter is created which stores a reference to the AMI. By default, this parameter is called `${var.ssm_paths.root}/${var.ssm_paths.config}/ami_id`. The housekeeper is a process that looks for AMIs which can be deleted because they're no longer used. It does this in a couple of ways: 1. Check the launch template for the AMI ID. 2. Check the SSM parameter. 3. Apply a threshold to not delete AMIs that are too new, according to the config. The problem is that we were looking for SSM parameters like this: ```typescript const ssmParams = await ssmClient.send( new DescribeParametersCommand({ ParameterFilters: [ { Key: "Name", Values: ["ami-id"], Option: "Contains", }, ], }), ); ``` i.e. we were looking for parameters which contain the hardcoded string `ami-id`. This is different to the new default of `ami_id`. So we weren't considering the right AMIs to be in use. What would be a better approach would be to reference the values dynamically. This means resolving from the template, and handling the passed-in options, if there are any. We're documenting that we support wildcards, so also support that here too. The default value in the launch template became `resolve:ssm:<id or AMI>`, so we need to make sure to ask EC2 to resolve for us when looking up the template. In that way we get the actual AMI ID rather than the alias. This can be a bit challenging to understand, so the comments are improved. Comprehensive tests are added to try to ensure this all works as expected. Closes: #4571 --------- Co-authored-by: Niek Palm <niek.palm@philips.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d860feb - Browse repository at this point
Copy the full SHA d860febView commit details -
chore(main): release 6.5.10 (#4626)
🤖 I have created a release *beep* *boop* --- ## [6.5.10](v6.5.9...v6.5.10) (2025-06-23) ### Bug Fixes * **ami-housekeeper:** don't delete referenced AMIs in default config ([#4623](#4623)) ([d860feb](d860feb)) * **docs:** github artifact attestation command in release notes ([#4624](#4624)) ([ff39d4f](ff39d4f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b20b99d - Browse repository at this point
Copy the full SHA b20b99dView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v6.5.9...v6.5.10