Skip to content

refactor: Repository.move filters nodes instead of deleting their sha #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AurelioDeRosa
Copy link
Member

closes #215

@AurelioDeRosa
Copy link
Member Author

@clayreimann do you know why the build keeps failing?

@clayreimann
Copy link
Member

clayreimann commented Jun 20, 2016

They need better isolation. The tests are pretty fragile, if you look at the build logs for each build that fails they all fail in different ways. Perhaps we just need to slow them down further (maybe 300-400ms between calls), but I think the thing we can do for the tests is to make sure that each test can run independently–so remove cross-test dependencies–and set mocha to retry failed tests a couple times. I've often found that running a build a second time will result in the build passing.

Also, we should update travis.yml to only build master and the tags, as in this example. That way PRs like this one don't kick off two different builds.

return ref;
});
})
.filter((ref) => ref.type !== 'tree');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add whitespace for clarity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Where do you want to place it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between this line and the return

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants