feature(repository): add getCombinedStatus #429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2017
|
Any news on this one? |
|
I'd really find this super useful if we could have it merged. Thanks in advance! :D |
|
LGTM |
|
Are the failing tests blocking this PR ? A quick look suggests the failing tests are not specific to this PR. |
|
@j-rewerts can you take a look at this one? |
This was referenced Aug 29, 2019
|
@bfeldkamp3 Apologies for not seeing this earlier. Closing in favour of #580. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
getCombinedStatusmethod inRepository.jsand an associated unit test to implement the GitHub get combined status API endpoint (https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref).NOTE: The one unit test which is failing is not actually a problem with the unit tests themselves, but rather is being caused by the test harnesses inability to properly authenticate to GitHub.
closes #426
@clayreimann
@mtscout6
@AurelioDeRosa
@alexcanessa