fix: make LiteLLM streaming truly asynchronous #1451
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
selcukgun
approved these changes
Jun 18, 2025
|
@selcukgun do you think we can get this released? This is causing a ton of issues in our production usage of ADK |
copybara-service bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Merge #1451 ## Description Fixes #1306 by using `async for` with `await self.llm_client.acompletion()` instead of synchronous `for` loop. ## Changes - Updated test mocks to properly handle async streaming by creating an async generator - Ensured proper parameter handling to avoid duplicate stream parameter ## Testing Plan - All unit tests now pass with the async streaming implementation - Verified with `pytest tests/unittests/models/test_litellm.py` that all streaming tests pass - Manually tested with a sample agent using LiteLLM to confirm streaming works properly # Test Evidence: https://youtu.be/hSp3otI79DM Let me know if you need anything else from me for this PR COPYBARA_INTEGRATE_REVIEW=#1451 from avidelatm:fix/litellm-async-streaming d35b9dc PiperOrigin-RevId: 774835130
|
@selcukgun This got merged, do I close the PR now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1306 by using
async forwithawait self.llm_client.acompletion()instead of synchronousforloop.Changes
Testing Plan
pytest tests/unittests/models/test_litellm.pythat all streaming tests passTest Evidence:
https://youtu.be/hSp3otI79DM
Let me know if you need anything else from me for this PR