Fixed issue with undefined initial zoom
#790
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: mount zoom value is not set, in process of work we set zoom to any value (eg. 12). condition always `false` `Math.abs(12 - undefined)` = `NaN`
EdPutans
approved these changes
Sep 30, 2019
|
@More4ever Is this from an open issue? |
|
Not sure it was too many days ago Probably it exists only as PR. I can create issue with same description and source code links if it is required |
|
@More4ever The problem is that I don't see the issue happening, so I don't know what you are fixing. Therefore yes, please! |
|
@More4ever I think this is a duplicate of #864, and I think #864 fixes the problem way better, what do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved Issue:
mount zoom value is not set, in process of work we set zoom to any value (eg. 12).
Math.abs(nextProps.zoom - this.props.zoom) > 0condition is alwaysfalseMath.abs(12 - undefined)=NaN