-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(storage): allow Accept-Encoding header #2758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
kokoro error: apigee/v1/apigee-gen.go:12017:52: not enough arguments in call to gensupport.SendRequest
have (context.Context, *"net/http".Client, *"net/http".Request)
want (context.Context, *"net/http".Client, *"net/http".Request, bool) |
In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as @codyoss and I usually do. (Recent example in #2670.) You can do it by running |
I updated everything, but am still seeing errors locally (I can't see the kokoro build):
This seems unrelated to the changes I made, can you help me fix? |
@BrennaEpp is this a change we are still wanting to land? |
@codyoss Yes, it is. @frq-dev will work soon on getting this PR into shape. The first commit of this PR shows what we essentially want to do (without the noise of regenerating everything); I don't think we will change that code so feel free to review now or wait for conflicts etc to be resolved. |
Fixes #2757
Code needs to be regenerated to match up with the additional parameters in gensupport.