Skip to content

feat(storage): Restart & delete resumable upload #21896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
May 22, 2025
Merged

feat(storage): Restart & delete resumable upload #21896

merged 26 commits into from
May 22, 2025

Conversation

shubhangi-google
Copy link
Contributor

@shubhangi-google shubhangi-google commented Feb 27, 2025 •
edited
Loading

Feature to support Restart and Delete resumable upload functionality

@example   

storage = Google::Cloud::Storage.new
bucket = storage.bucket bucket_name
## sample upload_id=  "AKDAyIs3wDvKFtl2e4PopZi-YtGZDxFr2vlR4Z58T6hL9Seypi5W2s7vrRe6-Qw5Fur79g11bT7MtcsSu-vYRkm5nVUKPpm_ciLPn65GQDqNMQ"
#Initiating Resumable upload 
bucket.create_file file, file_name
#Restarting  Resumable upload 
bucket.restart_resumable_upload file, upload_id
#Deleting Resumable upload 
bucket.delete_resumable_upload upload_id

Implementation linked with- googleapis/google-cloud-ruby#29215

@shubhangi-google shubhangi-google requested a review from a team as a code owner February 27, 2025 10:00
@shubhangi-google shubhangi-google marked this pull request as draft February 27, 2025 10:01
@shubhangi-google shubhangi-google changed the title feat(storage):Restart delete resumable upload feat(storage): Restart delete resumable upload Feb 27, 2025
@shubhangi-google shubhangi-google marked this pull request as ready for review March 3, 2025 11:00
@shubhangi-google shubhangi-google mentioned this pull request Mar 3, 2025
Draft
@shubhangi-google shubhangi-google marked this pull request as draft March 10, 2025 05:23
@shubhangi-google shubhangi-google marked this pull request as ready for review March 11, 2025 04:08
bajajneha27
bajajneha27 reviewed Mar 11, 2025
View reviewed changes
@shubhangi-google shubhangi-google marked this pull request as draft April 24, 2025 12:05
@shubhangi-google shubhangi-google marked this pull request as ready for review May 2, 2025 09:23
@bajajneha27 bajajneha27 changed the title feat(storage): Restart delete resumable upload feat(storage): Restart & delete resumable upload May 2, 2025
bajajneha27
bajajneha27 reviewed May 2, 2025
View reviewed changes
bajajneha27
bajajneha27 reviewed May 9, 2025
View reviewed changes
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of questions. The review is getting stretched but we're nearly there.
I'm going to take another round of review to be sure of the design once again. Thanks.

shubhangi-google and others added 3 commits May 13, 2025 11:08
@shubhangi-google @bajajneha27
Update google-apis-core/lib/google/apis/core/storage_upload.rb
422dc99 
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
@shubhangi-google
:q
238a1e2
@shubhangi-google
updating requests
89e281d
bajajneha27
bajajneha27 reviewed May 16, 2025
View reviewed changes
shubhangi-google and others added 2 commits May 19, 2025 11:32
@shubhangi-google @bajajneha27
Update google-apis-core/lib/google/apis/core/storage_upload.rb
53b8d50 
Co-authored-by: Neha Bajaj <bajajneha27@users.noreply.github.com>
@shubhangi-google
Update base_service.rb
0a9bb3f
@bajajneha27 bajajneha27 merged commit 89d5f72 into googleapis:main May 22, 2025
9 checks passed
@release-please release-please bot mentioned this pull request May 22, 2025
Merged
This was referenced Jun 13, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubhangi-google @bajajneha27