Skip to content

chore!: remove ai.top_k(). #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025
Merged

chore!: remove ai.top_k(). #1842

merged 5 commits into from
Jun 24, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented Jun 23, 2025

We will add it back once AI scoring is ready on the SQL engine side.

BEGIN_COMMIT_OVERRIDE
BREAKING CHANGE: ai.top_k() is removed.
Release-As: 2.9.0
END_COMMIT_OVERRIDE

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 23, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jun 23, 2025
@sycai sycai requested a review from GarrettWu June 23, 2025 23:56
@sycai sycai marked this pull request as ready for review June 23, 2025 23:56
@sycai sycai requested review from a team as code owners June 23, 2025 23:56
@GarrettWu
Copy link
Contributor

Will it be a different API or the same API for AI scoring?

@sycai
Copy link
Contributor Author

sycai commented Jun 24, 2025

Will it be a different API or the same API for AI scoring?

We will probably provide both ai.score() and ai.top_k(), but the parameter list remains to be decided.

Another concern is that the current approach (divide-and-conquer) is unlikely to be consistent with AI scoring. Due to the mercuriality of the AI responses, there's a chance that the current approach gets stuck indefinitely. We'd better play it safe.

@sycai sycai enabled auto-merge (squash) June 24, 2025 20:52
@sycai sycai merged commit c06d8db into main Jun 24, 2025
18 of 25 checks passed
@sycai sycai deleted the sycai_ai_ops branch June 24, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants