-
Notifications
You must be signed in to change notification settings - Fork 50
chore: add benchmarks for read_gbq_colab #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Marking as |
group_column = "col_int64_1" | ||
if group_column not in df.columns: | ||
group_column = "col_bool_0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I follow what is going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some column to group by and some tables with tiny rows can only fit a boolean. I can add a comment.
|
||
# Simulate the user filtering by a column and visualizing those results | ||
df_filtered = df[df["col_bool_0"]] | ||
df_filtered.shape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These .shape calls are going to be pretty brutal, going to double-execute
Follow-up to #1846
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards internal issue b/420984164 🦕