Skip to content

fix: generate GoogleSQL instead of legacy SQL data types for dry_run=True from bpd._read_gbq_colab with local pandas DataFrame #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 30, 2025
Merged

fix: generate GoogleSQL instead of legacy SQL data types for dry_run=True from bpd._read_gbq_colab with local pandas DataFrame #1867

merged 8 commits into from
Jun 30, 2025
+713 −47

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jun 27, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue b/428190014 🦕

@tswast
fix: generate GoogleSQL instead of legacy SQL data types for `dry_run…
9fb069f 
…=True` from `bpd._read_gbq_colab` with local pandas DataFrame
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 27, 2025
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 27, 2025
@tswast tswast marked this pull request as ready for review June 27, 2025 21:32
@tswast tswast requested review from a team as code owners June 27, 2025 21:32
@tswast tswast requested a review from TrevorBergeron June 27, 2025 21:32
@tswast tswast merged commit fab3c38 into main Jun 30, 2025
23 of 25 checks passed
@tswast tswast deleted the b428190014-read_gbq_colab-dry_run-googlesql branch June 30, 2025 13:33
@release-please release-please bot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @TrevorBergeron @Genesis929