Skip to content

fix: Fix bug with DataFrame.agg for string values #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2025
Merged

fix: Fix bug with DataFrame.agg for string values #1870

merged 3 commits into from
Jun 30, 2025
+82 −17

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 27, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review June 27, 2025 23:08
@TrevorBergeron TrevorBergeron requested review from a team as code owners June 27, 2025 23:08
@TrevorBergeron TrevorBergeron requested a review from shuoweil June 27, 2025 23:08
shuoweil
shuoweil previously approved these changes Jun 28, 2025
View reviewed changes
@shuoweil
Copy link
Contributor

It is better to check the following two testcases:
FAILED tests/system/small/test_window.py::test_dataframe_rolling_on_invalid_column_raise_error
FAILED tests/system/small/test_window.py::test_dataframe_groupby_rolling_on_invalid_column_raise_error

@shuoweil shuoweil self-requested a review June 30, 2025 04:31
@TrevorBergeron TrevorBergeron merged commit 81e4d64 into main Jun 30, 2025
25 checks passed
@TrevorBergeron TrevorBergeron deleted the b428037029 branch June 30, 2025 16:52
@release-please release-please bot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoweil shuoweil shuoweil approved these changes

Assignees

@Genesis929 Genesis929

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @shuoweil @Genesis929