-
Notifications
You must be signed in to change notification settings - Fork 432
feat(sdk): Add Rust SDK #7578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Add Rust SDK #7578
Conversation
caveats: - logs aren't shown on stdout
|
This is a WIP, no need to review yet, I'll un-draft the PR when it's ready :) |
@Vadman97 @ccschmitz This is ready to go :) I mainly focused on writing docs for the highlight site, so our docs.rs site might not look the best, but that is fine in my opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for all the hard work @mogery, and for the thorough testing in the youtube video!
would appreciate your thoughts on how we should publish the packages as rust cargo. once we have that figured out, this will be ready to merge!
awesome! been having some super busy days. will get the cargo info to you on tuesday though. are we looking for a CI automated option or just manual is fine? |
CI automated would be ideal. i can help with testing it though via a branch to validate the secrets needed etc. |
friendly bump here @mogery |
sorry @Vadman97! been super busy lately. i've got another thing's deadline tonight, will 100% get on this tomorrow. |
Seems like we'll need to publish the crate manually first, and then we can use this action to automatically detect changes and publish new versions. Could we coordinate this first push over Discord or some other real-time chat? I can walk you through it so that you get the publish token & ownership. |
another bump here @mogery . if you think this is in a close spot, i can pull the CI work into a new ticket |
I can work on this now, I posted a comment with info 4 hours ago. |
Added the READMEs and the GitHub Action. Not sure how to make the action actually run in this PR though. Maybe it only runs once merged. |
looks like the current working directory isn't set right? |
oops! pushed a fix 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet! thanks for getting the CI done as part of this too 🙏
@all-contributors please add @mogery for code |
I've put up a pull request to add @mogery! 🎉 |
Adds @mogery as a contributor for code. This was requested by SpennyNDaJets [in this comment](#7578 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Summary
Fixes #6756
/claim #6756
This PR adds two new Rust SDK crates,
highlightio
andhighlightio-actix
, for capturing logs and errors & instrumenting Rust code. These depend heavily on the variousopentelemetry
libraries.To-do
Known issues
logging is not shown on stdout, only sent to the serverHow did you test this change?
I wrote examples in
sdk/highlight-rust/*/examples
and validated them using my highlight.io profile.Are there any deployment considerations?
You need to publish the crates in
sdk/highlight-rust
.