Skip to content

Create Feature Request Issue Form #5651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Create Feature Request Issue Form #5651

wants to merge 8 commits into from

Conversation

adityaraute
Copy link

Summary

Fixes #5650
Adds a new Issue Form for Feature Requests

Checklist

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 6, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@adityaraute adityaraute marked this pull request as ready for review April 6, 2025 09:34
@mgol
Copy link
Member

mgol commented Apr 6, 2025

Thanks for the PR. Please sign our CLA, we cannot merge contributed code otherwise.

@adityaraute adityaraute changed the title Create Feature Request.yml Create Feature Request Issue Form Apr 7, 2025
@adityaraute
Copy link
Author

Thanks for the PR. Please sign our CLA, we cannot merge contributed code otherwise.

Done!

mgol
mgol requested changes Apr 13, 2025
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I tried this on my fork but it doesn't work. I recommend you to temporarily enable issues on your jQuery fork and to set the patch-1 branch as the main one and you'll be able to check what's needed. In particular, I think we need a config.yml file: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

Also, if we want to introduce a feature request form, please make sure the path to report regular bug reports is at least not harder than it was - maybe we need to create a form for bug reports as well, even if for now it won't ask that many questions (we can always improve it later)?

@adityaraute
Copy link
Author

I recommend you to temporarily enable issues on your jQuery fork and to set the patch-1 branch as the main one and you'll be able to check what's needed.

I had done this before creating the PR. Not sure what's the issue is about. I'll look into the link you shared.

maybe we need to create a form for bug reports as well

I'll add in this PR itself

@adityaraute adityaraute marked this pull request as draft April 15, 2025 20:20
@adityaraute
Copy link
Author

Screenshots:

  1. When you click on New Issue
    {617CEF99-95E1-4B23-AB53-15E4A9CDCB28}

  2. Bug Report Form
    {A44FA18F-2975-4C4A-9B7B-C90D572A48AB}

  3. Feature Request Form
    {6C99B482-F26A-4213-B23D-43A63EFFA5A7}

Hope you are able to replicate this in your repo

@adityaraute adityaraute marked this pull request as ready for review April 15, 2025 20:41
@adityaraute adityaraute requested a review from mgol April 24, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol Awaiting requested review from mgol

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Issue Forms / Templates
2 participants
@adityaraute @mgol