[12.x] Explicitly bind Console Kernel in bootstrap/app.php for … #6633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proper Artisan command and schedule handling
### Issue
With the new fluent configuration API introduced in Laravel 12 for `bootstrap/app.php`, the Console Kernel is not automatically registered in the service container. This causes scheduled commands and Artisan commands to fail silently or report messages like:
> No scheduled commands are ready to run.
and prevents proper execution of Artisan commands.
---
### Solution
This pull request explicitly binds the `Illuminate\Contracts\Console\Kernel` interface to the `App\Console\Kernel` implementation inside `bootstrap/app.php`. This ensures that the framework can correctly resolve the Console Kernel when handling scheduled tasks and Artisan commands.
---
### Changes made
Added the following binding in `bootstrap/app.php`:
```php
use Illuminate\Contracts\Console\Kernel as ConsoleKernelContract;
use App\Console\Kernel as AppConsoleKernel;
$app->singleton(ConsoleKernelContract::class, function ($app) {
return $app->make(AppConsoleKernel::class);
});
GrahamCampbell
changed the title
|
I think it should be made in the core for two reasons:
|
|
I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework. Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…proper Artisan command and schedule handling
Issue
With the new fluent configuration API introduced in Laravel 12 for
bootstrap/app.php, the Console Kernel is not automatically registered in the service container. This causes scheduled commands and Artisan commands to fail silently or report messages like:and prevents proper execution of Artisan commands.
Solution
This pull request explicitly binds the
Illuminate\Contracts\Console\Kernelinterface to theApp\Console\Kernelimplementation insidebootstrap/app.php. This ensures that the framework can correctly resolve the Console Kernel when handling scheduled tasks and Artisan commands.Changes made
Added the following binding in
bootstrap/app.php: