dzsave: IIIF: use named region of 'full' when no crop takes place #4578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should improve conformance with IIIF v2 and v3, the specs of which both mandate support for the 'full' region. Also adds a couple of initial, basic IIIF layout tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will improve compliance with IIIF v2 and v3, the specs of which both mandate support for the "full" region.
I've checked OpenLayers and OpenSeadragon and they both contain the same logic so it should address most of #2036
This PR only handles the "region" part of the URL and doesn't touch the "size" as (I think) as long as the tile size is smaller than the original image size in either (or both) dimensions then a "max" tile will not be requested. If the tile size is larger than the original image in both dimensions then there's only one tile/layer, so you don't really need dzsave.
I've also added a couple of initial, basic IIIF layout tests as there were none. I used the sample dimensions from #4576 for these as it should be fixed too.