CFNv2: support dynamic parameter resolution #12797
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: minor
simonrw
force-pushed
the
cfn/v2/dynamic-ssm-lookup
branch
from
acc5133 to
6574897
Compare
MEPalma
reviewed
Jun 26, 2025
| @@ -1040,7 +1045,23 @@ def visit_node_array(self, node_array: NodeArray) -> PreprocEntityDelta: | |||
| return PreprocEntityDelta(before=before, after=after) | |||
|
|
|||
| def visit_node_property(self, node_property: NodeProperty) -> PreprocEntityDelta: | |||
| return self.visit(node_property.value) | |||
| # TODO: is this the right place? | |||
There was a problem hiding this comment.
Are dynamic parameters only resolved at a property level? For example, these are never resolved as input for another intrinsic function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The V2 engine does not currently support resolving dynamic parameter values, e.g.
Changes