-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
SES: add snapshot test for describe_configuration_set with SNS destinations #12814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.
f699351
to
7684f3a
Compare
I have read the CLA Document and I hereby sign the CLA |
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 2m 44s ⏱️ - 1h 42m 48s For more details on these failures, see this check. Results for commit 67618e2. ± Comparison against base commit 05a922a. This pull request removes 4751 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 11m 47s ⏱️ For more details on these failures, see this check. Results for commit 67618e2. ♻️ This comment has been updated with latest results. |
…ations Related to issue #12722 Requires getmoto/moto#9023
7684f3a
to
67618e2
Compare
Motivation
As reported in #12722,
describe_configuration_set
is missing SNS event destinations.This is addressed in getmoto/moto#9023 and this PR complements the parity enhancement with a snapshot test.
Changes
Only tests.
Testing
TODO