Skip to content

FIX: remove idle_event #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

FIX: remove idle_event #13403

merged 1 commit into from
Feb 11, 2019

Conversation

jklymak
Copy link
Member

@jklymak jklymak commented Feb 11, 2019 •
edited
Loading

PR Summary

OK, so I screwed up merging #9845 because it called a deprecated method. I guess we ned to make sure PRs run on modern tests if they are so old. My apologies.

Anyways, this PR removes the deprecated method.

NOTE: this unbreaks CI...

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak added this to the v3.1.0 milestone Feb 11, 2019
@jklymak jklymak added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Feb 11, 2019
@jklymak jklymak closed this Feb 11, 2019
@jklymak jklymak deleted the fix-IdleEvent branch February 11, 2019 00:56
@lkjell
Copy link
Contributor

lkjell commented Feb 11, 2019

This still valid PR @jklymak ?

@jklymak jklymak restored the fix-IdleEvent branch February 11, 2019 04:57
@jklymak jklymak reopened this Feb 11, 2019
@jklymak
Copy link
Member Author

jklymak commented Feb 11, 2019

@lkjell Yes, we need to do this because we removed IdleEvent....

@anntzer
Copy link
Contributor

anntzer commented Feb 11, 2019

CI still broken with qt, but this is a first step...

@anntzer anntzer added the Build label Feb 11, 2019
@anntzer anntzer merged commit d31d102 into matplotlib:master Feb 11, 2019
@anntzer anntzer mentioned this pull request Mar 23, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@lkjell lkjell lkjell approved these changes

Assignees
No one assigned
Labels
Build Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jklymak @lkjell @anntzer @tacaswell