Remove font preamble caching in TexManager. #14044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 26, 2019
anntzer
force-pushed
the
texmancache
branch
3 times, most recently
from
da709cf to
16bb59b
Compare
QuLogic
approved these changes
Mar 22, 2020
TexManager has a complex caching machinery (... among other caching layers) to map font-related rcParams to a tex preamble (see `_rc_cache`, `_rc_cache_keys`, `_reinit`) but that's just a matter of a few dict lookups which are negligible compared to invoking the subprocess; so just strip out that caching and always regenerate the font-related preamble. That caching also set some attributes (`texmanager.serif`, etc.) as a side-effect via `setattr`/`getattr`, which are used nowhere else (and it's hard to know they even exist other than figuring out the relevant `setattr` calls); just deprecate them.
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TexManager has a complex caching machinery (... among other caching
layers) to map font-related rcParams to a tex preamble (see
_rc_cache,_rc_cache_keys,_reinit) but that's just a matter of a few dictlookups which are negligible compared to invoking the subprocess; so
just strip out that caching and always regenerate the font-related
preamble.
That caching also set some attributes (
texmanager.serif, etc.) as aside-effect via
setattr/getattr, which are used nowhere else (andit's hard to know they even exist other than figuring out the relevant
setattrcalls); just deprecate them.(I have some followup cleanups on that...)
PR Summary
PR Checklist