Skip to content

Deprecate toggling axes navigatability using the keyboard. #16529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

Deprecate toggling axes navigatability using the keyboard. #16529

merged 2 commits into from
Feb 18, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 16, 2020

I made the backend_tools version just point to backend_bases to avoid
repeating the deprecation.

See discussion at #11432 (TL;DR: this feature is both confusing and buggy).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Feb 16, 2020
@anntzer anntzer force-pushed the keynav branch 2 times, most recently from d92e3db to f8d41e8 Compare February 16, 2020 19:29
tacaswell
tacaswell approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo rebase and CI passing.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 16, 2020

rebased

@tacaswell
Copy link
Member

needs yet another rebase.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 18, 2020

rebased

@anntzer @tacaswell
Deprecate toggling axes navigatability using the keyboard.
8987d43 
I made the backend_tools version just point to backend_bases to avoid
repeating the deprecation.
@anntzer @tacaswell
Update missing_references.json.
c1c2fcb
@tacaswell
Copy link
Member

rebased yet again (this time conflicts with the docstring clean up PR).

@anntzer
Copy link
Contributor Author

anntzer commented Feb 18, 2020

thanks :p

@tacaswell tacaswell merged commit 5ea78e1 into matplotlib:master Feb 18, 2020
@tacaswell
Copy link
Member

merged before we got another conflict

@anntzer anntzer deleted the keynav branch February 18, 2020 19:42
@anntzer anntzer mentioned this pull request Mar 23, 2020
Closed
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Apr 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @timhoffm