Skip to content

Avoid spurious deprecation warning in TextBox. #17043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 6, 2020

PR Summary

Closes #17033.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.2.2 milestone Apr 6, 2020
@timhoffm timhoffm merged commit 3f78c1a into matplotlib:master Apr 7, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 7, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 3f78c1a7c61de377f682e30b872bf77a6a094467
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #17043: Avoid spurious deprecation warning in TextBox.'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-17043-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #17043 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@timhoffm
Copy link
Member

Does not need backporting. The offending rc_context was introduced later, v3.2.x still manually sets and resets rcParams instead.

@QuLogic QuLogic modified the milestones: v3.2.2, v3.3.0 Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a TextBox in current master produces a seemingly unrelated warning.
4 participants