Skip to content

Addition of numticks=N in LogLocator #20950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

manushree635
Copy link

@manushree635 manushree635 commented Aug 31, 2021

Addition of numticks=N in LogLocator in def _autolev(self, N):

PR Summary

"closes #19856"
Contour plots don't interact nicely with matplotlib.colors.LogNorm. Level=N doesn't work with LogNorm.
Added numticks=N in LogLocator in def _autolev(self, N):

PR Checklist

  • [ N/A] Has pytest style unit tests (and pytest passes).
  • [N/A] Is Flake 8 compliant (run flake8 on changed files to check).
  • [ N/A] New features are documented, with examples if plot related.
  • [ N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [N/A] Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A ] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

QuLogic and others added 4 commits August 30, 2021 17:07
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@jklymak
Copy link
Member

jklymak commented Aug 31, 2021

@manushree635 Thanks a lot for the PR. Can you tidy up a bit and add a descriptive title and link the issue in the description instead of the title? If you say "closes #19856" it will automatically close.

Without looking at the original issue, I suspect you will want to add a test so that this doesn't break in the future.

@manushree635
Copy link
Author

@manushree635 Thanks a lot for the PR. Can you tidy up a bit and add a descriptive title and link the issue in the description instead of the title? If you say "closes #19856" it will automatically close.

Without looking at the original issue, I suspect you will want to add a test so that this doesn't break in the future.

done

@jklymak jklymak changed the title Manushree635 issue#19856 Addition of numticks=N in LogLocator Aug 31, 2021
@jklymak
Copy link
Member

jklymak commented Aug 31, 2021

Thanks - this needs to pass the current test suite and preferably would have a new test.

@tacaswell
Copy link
Member

This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details.

To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote "upstream"

git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease   # assuming you are tracking your branch

If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you.

Thank you for your contributions to Matplotlib and sorry for the inconvenience.

@melissawm
Copy link
Member

Hi @manushree635 - are you interested in continuing this work? Please let us know if you need help moving forward. Cheers!

@dstansby
Copy link
Member

Given this is very old with no response, and is made obsolete by #27576, I'm going to close. Thanks for opening!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

BUG: Contours with LogNorm
7 participants