-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Addition of numticks=N in LogLocator #20950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of numticks=N in LogLocator #20950
Conversation
Switch documented deprecations in mathtext by `__getattr__` deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
@manushree635 Thanks a lot for the PR. Can you tidy up a bit and add a descriptive title and link the issue in the description instead of the title? If you say "closes #19856" it will automatically close. Without looking at the original issue, I suspect you will want to add a test so that this doesn't break in the future. |
done |
Thanks - this needs to pass the current test suite and preferably would have a new test. |
This PR is affected by a re-writing of our history to remove a large number of accidentally committed files see discourse for details. To recover this PR it will need be rebased onto the new default branch (main). There are several ways to accomplish this, but we recommend (assuming that you call the matplotlib/matplotlib remote git remote update
git checkout main
git merge --ff-only upstream/main
git checkout YOUR_BRANCH
git rebase --onto=main upstream/old_master
# git rebase -i main # if you prefer
git push --force-with-lease # assuming you are tracking your branch If you do not feel comfortable doing this or need any help please reach out to any of the Matplotlib developers. We can either help you with the process or do it for you. Thank you for your contributions to Matplotlib and sorry for the inconvenience. |
Hi @manushree635 - are you interested in continuing this work? Please let us know if you need help moving forward. Cheers! |
Given this is very old with no response, and is made obsolete by #27576, I'm going to close. Thanks for opening! |
Addition of numticks=N in LogLocator in def _autolev(self, N):
PR Summary
"closes #19856"
Contour plots don't interact nicely with matplotlib.colors.LogNorm. Level=N doesn't work with LogNorm.
Added numticks=N in LogLocator in def _autolev(self, N):
PR Checklist
pytest
passes).flake8
on changed files to check).flake8-docstrings
and runflake8 --docstring-convention=all
).doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).