Skip to content

Issue Fix #21959 #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Issue Fix #21959 #22130

wants to merge 2 commits into from

Conversation

35C4n0r
Copy link

@35C4n0r 35C4n0r commented Jan 6, 2022 •
edited
Loading

In case of ValueError caused by user given input, raw string will be displayed in Error Message.
Example:

raise ValueError(
                        f"'c' argument must be a color, a sequence of colors, "
                        f"or a sequence of numbers, not {c!r}")

PR Summary

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (and pytest passes).
  • [N/A ] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [ N/A] New features are documented, with examples if plot related.
  • [N/A ] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [ N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@35C4n0r
Issue Fix matplotlib#21959
82aa3a5 
In case of ValueError caused by user given input, raw string will be displayed in Error Message.
github-actions[bot]
github-actions bot reviewed Jan 6, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@35C4n0r
Bug Fixed
7e8e742 
Error on line 6601 fixed.
@QuLogic QuLogic added the status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default. label Jan 7, 2022
@QuLogic
Copy link
Member

QuLogic commented Jan 7, 2022

Please give you PR/commit message more informative titles. No-one's going to click on a PR to review if the message doesn't say anything that they understand.

@jklymak
Copy link
Member

jklymak commented Jan 20, 2022

Thanks for this. You have a flake8 error, and your new test isn't passing. I've moved to draft until you can fix it. Thanks,

@jklymak jklymak marked this pull request as draft January 20, 2022 08:27
@QuLogic
Copy link
Member

QuLogic commented Nov 10, 2022

Replaced by #24403.

@QuLogic QuLogic closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
status: needs revision status: needs workflow approval For PRs from new contributors, from which GitHub blocks workflows by default.
Projects
First Time Contributors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@35C4n0r @QuLogic @jklymak