Skip to content

Refactor axislines nth_coord #26066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Jun 4, 2023

PR summary

PR checklist

@oscargus oscargus marked this pull request as ready for review June 4, 2023 14:27
@anntzer
Copy link
Contributor

anntzer commented Jun 4, 2023

Does that really need a public setter? Is there any of the downstream code that could reasonably make use of that functionality? Does the rest of the code even work (eg are caches invalidated properly) if you change nth_coord?

If anything it make make more sense to deprecate direct attribute access to make that immutable. (I'm not sure any of the downstream code even really needs access to that...)

@oscargus
Copy link
Member Author

oscargus commented Jun 4, 2023

Good question. The main thing was really to move the common get_nth_coord and then the rest just followed.

There is an example for a private method (replying from the phone...) where it is changed, but I haven't checked more.

You are probably correct that it may make more sense to make it a private attribute. Will have a further look at it.

@oscargus oscargus marked this pull request as draft June 4, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants