Deprecate BboxBase.corners. #26878
Open
Deprecate BboxBase.corners. #26878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksunden
reviewed
Sep 22, 2023
... which is used only internally in one place, and can be easily inlined. Possibly in prevision for repurposing the name for other purposes.
|
FYI |
|
Moving this to 3.10, as @inferentialist makes a compelling case for it being used "in the wild" and @timhoffm has a bunch of thoughts on what the API should be that I don't think we fully hashed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... which is used only internally in one place, and can be easily inlined. Possibly in prevision for repurposing the name for other purposes.
See discussion at #26805.
PR summary
PR checklist