Fixed PolarAxes not using fmt_xdata and added simple test (#4568) #28306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are those 2 checks from azure pipelines supposed to fail? I've noticed some other pull requests fail on exactly the same test. |
timhoffm
reviewed
Jun 2, 2024
greglucas
reviewed
Jun 8, 2024
lib/matplotlib/projections/polar.py
Outdated
Comment on lines
1456
to
1458
| format_sig(r, delta_r, "#", "g") | ||
| if self.fmt_ydata is None | ||
| else self.format_ydata(r) |
There was a problem hiding this comment.
I was a bit confused by this portion as well when first glancing at this because it is duplicated below. I think this might be nice to bring outside the fmt_xdata if statement:
r_label = ... and then reference r_label here and the following code block.
lib/matplotlib/tests/test_polar.py
Outdated
Comment on lines
450
to
458
| def test_custom_fmt_xdata(): | ||
| ax = plt.subplot(projection="polar") | ||
| def millions(x): | ||
| return '$%1.1fM' % (x*1e-6) | ||
|
|
||
| ax.fmt_xdata = millions | ||
| assert ax.format_coord(2e5, 1) == "θ=$0.2M, r=1.000" | ||
| assert ax.format_coord(1, .1) == "θ=$0.0M, r=0.100" | ||
| assert ax.format_coord(1e6, 0.005) == "θ=$1.0M, r=0.005" |
There was a problem hiding this comment.
Could you also add a test for the case with both fmt_xdata and fmt_ydata set?
It might be easier to do this all within a single test and add comments for the various cases.
Suggested change
| def test_custom_fmt_xdata(): | |
| ax = plt.subplot(projection="polar") | |
| def millions(x): | |
| return '$%1.1fM' % (x*1e-6) | |
| ax.fmt_xdata = millions | |
| assert ax.format_coord(2e5, 1) == "θ=$0.2M, r=1.000" | |
| assert ax.format_coord(1, .1) == "θ=$0.0M, r=0.100" | |
| assert ax.format_coord(1e6, 0.005) == "θ=$1.0M, r=0.005" | |
| def test_custom_fmt_xdata(): | |
| ax = plt.subplot(projection="polar") | |
| def millions(x): | |
| return '$%1.1fM' % (x*1e-6) | |
| # Test only x formatter | |
| ax.fmt_xdata = millions | |
| ax.fmt_ydata = None | |
| assert ax.format_coord(2e5, 1) == "θ=$0.2M, r=1.000" | |
| assert ax.format_coord(1, .1) == "θ=$0.0M, r=0.100" | |
| assert ax.format_coord(1e6, 0.005) == "θ=$1.0M, r=0.005" | |
| # Test only y formatter | |
| ax.fmt_xdata = None | |
| ax.fmt_ydata = millions | |
| ... | |
| # Test both x and y formatters | |
| ax.fmt_xdata = millions | |
| ax.fmt_ydata = millions | |
| ... |
greglucas
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
I've fixed
PolarAxesto usefmt_xdataandfmt_ydataand added a few simple tests to test that functionality. (#4568)PR checklist
fmt_randfmt_thetamethods to polar axes #4568" is in the body of the PR description to link the related issue