Skip to content

DOC: Emphasize artist as annotation in AnnotationBbox demo and add to annotation guide #29374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

DOC: Emphasize artist as annotation in AnnotationBbox demo and add to annotation guide #29374

wants to merge 1 commit into from
+131 −51

Conversation

story645
Copy link
Member

PR summary

Motivated by wanting to position an image relative to text and being confused, I reworked the AnnotationBBox demo:

  • emphasize that this is a method for using artists as annotations, because that wasn't clear to me when I was looking through the docs
  • broke up the demo into separate sections (text, image, arbitrary artist based on the different offset box classes) because I was having trouble keeping my place and mapping code to image when I was using this example to make something.

Also added AnnotationBbox to the Annotation guide because it's currently not there.

Current docs:

PR checklist

@github-actions github-actions bot added Documentation: examples files in galleries/examples Documentation: user guide files in galleries/users_explain or doc/users labels Dec 22, 2024
@story645 story645 force-pushed the annotationbbox branch 2 times, most recently from 04e428f to 91d2558 Compare December 23, 2024 05:35
@story645 story645 changed the title DOC: break up AnnotationBbox demo and add AnnotationBbox to annotation guide DOC: Emphasize artist as annotation in AnnotationBbox demo and add to annotation guide Dec 24, 2024
timhoffm
timhoffm reviewed Dec 29, 2024
View reviewed changes
@story645 @timhoffm
breakup annotationbbox demo and add annotationbbox to annotation guide
cc76e51 
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@story645 story645 marked this pull request as draft January 21, 2025 05:02
@story645
Copy link
Member Author

putting back to draft cause dunno when I'll get around to documenting offsetImage and BboxImage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation: examples files in galleries/examples Documentation: user guide files in galleries/users_explain or doc/users topic: annotation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@story645 @timhoffm