-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add ability to toggle legend in the figure options dialog box #30128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ability to toggle legend in the figure options dialog box #30128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
@rcomer gentle ping to help review this PR, this will be my first contribution to matplotlib. Please let me know if there are any changes to be made :) |
I’m sorry but I am not currently available for reviewing. I also am not familiar with this part of the library so it is unlikely I will review it when I am available again. |
@ritvi-alagusanka please add some tests for your code. You may wanna look at the tests for similar features as a model |
@story645 I have added a test case for this feature, the PR is now ready for your review |
PR summary
Added the ability to toggle legend in the figure options dialog box, solving issue #11109. Changes in the PR:
PR checklist