-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
FIX: Ensure Locators on RadialAxis are always correctly wrapped #30174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
All the wrapping logic is now contained in RadialAxis Closes matplotlib#30164 and rearchitects matplotlib#29798.
If you stick a |
diff --git a/lib/matplotlib/projections/polar.py b/lib/matplotlib/projections/polar.py
index f20498b271..40f431aefb 100644
--- a/lib/matplotlib/projections/polar.py
+++ b/lib/matplotlib/projections/polar.py
@@ -444,7 +444,7 @@ class RadialLocator(mticker.Locator):
if _is_full_circle_rad(*self._axes.viewLim.intervalx):
rorigin = self._axes.get_rorigin() * self._axes.get_rsign()
if self._axes.get_rmin() <= rorigin:
- return [tick for tick in self.base() if tick > rorigin]
+ return [tick for tick in self.base() if tick >= rorigin]
return self.base()
def _zero_in_bounds(self): ☝️ fixes the test that's broken - seems like a sensible change to make, but I'm not sure if it breaks any other tests. |
Thanks for figuring out. Actually, there is no tick at the center in all the polar examples. From a quick look, I don’t fully understand the code you pointed to, but given this is under the cross check: MATLAB does not do this. So it’s at least not something built in to match their behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than fixing the test.
All the wrapping logic is now done whenever a new locator is set in RadialAxis.
Closes #30164 and rearchitects #29798.