Skip to content

BUG: Include python-including headers first in src/ft2font.{cpp,h} #30220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025

Conversation

DWesl
Copy link
Contributor

@DWesl DWesl commented Jun 28, 2025

PR summary

Python.h defines several visibility macros on my platform. If system headers are included before Python.h, they will define the visibility macros to default values, causing compilation errors due to the conflicting definitions. This follows python.org guidelines.

I moved the groups that looked like headers that included Python.h before all other include statements in the file.
These changes allow matplotlib to compile into a wheel on my platform (Cygwin).

PR checklist

@QuLogic QuLogic added this to the v3.11.0 milestone Jun 28, 2025
@timhoffm timhoffm merged commit 75c9b0a into matplotlib:main Jun 28, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants