BUG: Include python-including headers first in src/ft2font.{cpp,h} #30220
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Python.h defines several visibility macros on my platform. If system headers are included before Python.h, they will define the visibility macros to default values, causing compilation errors due to the conflicting definitions. This follows python.org guidelines.
I moved the groups that looked like headers that included Python.h before all other include statements in the file.
These changes allow matplotlib to compile into a wheel on my platform (Cygwin).
PR checklist